[clang] [clang-tools-extra] [lldb] [llvm] [SystemZ][z/OS] Propagate IsText parameter to open text files as text (PR #107906)

kadir çetinkaya via cfe-commits cfe-commits at lists.llvm.org
Fri Sep 20 05:05:03 PDT 2024


================
@@ -121,8 +121,18 @@ ContentCache::getBufferOrNone(DiagnosticsEngine &Diag, FileManager &FM,
   // Start with the assumption that the buffer is invalid to simplify early
   // return paths.
   IsBufferInvalid = true;
-
-  auto BufferOrError = FM.getBufferForFile(*ContentsEntry, IsFileVolatile);
+  bool IsText = false;
----------------
kadircet wrote:

in all other code paths, `IsText` always defaults to true, but you're making it default to `false` here, is this intentional ?

https://github.com/llvm/llvm-project/pull/107906


More information about the cfe-commits mailing list