[clang] [llvm] [SPIRV][RFC] Rework / extend support for memory scopes (PR #106429)

Vyacheslav Levytskyy via cfe-commits cfe-commits at lists.llvm.org
Fri Sep 20 02:18:19 PDT 2024


================
@@ -1,7 +1,7 @@
 ; RUN: llc -O0 -mtriple=spirv32-unknown-unknown %s -o - | FileCheck %s --check-prefix=CHECK-SPIRV
 
 ; CHECK-SPIRV:      %[[#Int:]] = OpTypeInt 32 0
-; CHECK-SPIRV-DAG:  %[[#MemScope_Device:]] = OpConstant %[[#Int]] 1
+; CHECK-SPIRV-DAG:  %[[#MemScope_AllSvmDevices:]] = OpConstant %[[#Int]] 0
----------------
VyacheslavLevytskyy wrote:

I think it's better to be consistent in terminology of tests vs. source code, and to use here and in other tests CrossDevice instead of AllSvmDevices.

https://github.com/llvm/llvm-project/pull/106429


More information about the cfe-commits mailing list