[clang] [llvm] adding clang codegen (PR #109331)

Sarah Spall via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 19 16:09:59 PDT 2024


================
@@ -18824,6 +18824,40 @@ case Builtin::BI__builtin_hlsl_elementwise_isinf: {
         retType, CGM.getHLSLRuntime().getSignIntrinsic(),
         ArrayRef<Value *>{Op0}, nullptr, "hlsl.sign");
   }
+  // This should only be called when targeting DXIL
+  case Builtin::BI__builtin_hlsl_asuint_splitdouble: {
+
+    assert((E->getArg(0)->getType()->isDoubleType() ||
----------------
spall wrote:

Shouldn't this assert use && here instead of || because all of those need to be true? As it is now if any of them are true the assert won't be triggered, and the code should assert if any one of them are false. 

https://github.com/llvm/llvm-project/pull/109331


More information about the cfe-commits mailing list