[clang] [PAC] Re-sign a pointer to a noexcept member function when it is converted to a pointer to a member function without noexcept (PR #109056)
John McCall via cfe-commits
cfe-commits at lists.llvm.org
Thu Sep 19 10:34:20 PDT 2024
================
@@ -2419,8 +2419,13 @@ Value *ScalarExprEmitter::VisitCastExpr(CastExpr *CE) {
return Visit(const_cast<Expr*>(E));
case CK_NoOp: {
- return CE->changesVolatileQualification() ? EmitLoadOfLValue(CE)
- : Visit(const_cast<Expr *>(E));
+ if (CE->changesVolatileQualification())
+ return EmitLoadOfLValue(CE);
+ auto V = Visit(const_cast<Expr *>(E));
+ if (CGF.CGM.getCodeGenOpts().PointerAuth.CXXMemberFunctionPointers &&
+ CE->getType()->isMemberFunctionPointerType())
+ V = CGF.CGM.getCXXABI().EmitMemberPointerConversion(CGF, CE, V);
+ return V;
----------------
rjmccall wrote:
I mean the `CastKind`, not the expression class. We generally treat the conversion side of `CastExpr`s uniformly in CodeGen (although there are some important exceptions).
https://github.com/llvm/llvm-project/pull/109056
More information about the cfe-commits
mailing list