[clang] e818202 - [clang] Fix python comparison to None (#94014)

via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 19 07:33:16 PDT 2024


Author: Eisuke Kawashima
Date: 2024-09-19T16:33:12+02:00
New Revision: e8182029516dae445f21db304953aa5f10880d2d

URL: https://github.com/llvm/llvm-project/commit/e8182029516dae445f21db304953aa5f10880d2d
DIFF: https://github.com/llvm/llvm-project/commit/e8182029516dae445f21db304953aa5f10880d2d.diff

LOG: [clang] Fix python comparison to None (#94014)

from PEP8
(https://peps.python.org/pep-0008/#programming-recommendations):

> Comparisons to singletons like None should always be done with is or
is not, never the equality operators.

Co-authored-by: Eisuke Kawashima <e-kwsm at users.noreply.github.com>

Added: 
    

Modified: 
    clang/docs/DebuggingCoroutines.rst
    clang/tools/include-mapping/gen_std.py
    clang/utils/check_cfc/obj_diff.py
    clang/utils/module-deps-to-rsp.py

Removed: 
    


################################################################################
diff  --git a/clang/docs/DebuggingCoroutines.rst b/clang/docs/DebuggingCoroutines.rst
index 53bdd08fdbc02f..7f464c1f4f28ca 100644
--- a/clang/docs/DebuggingCoroutines.rst
+++ b/clang/docs/DebuggingCoroutines.rst
@@ -513,7 +513,7 @@ So we can use the ``continuation`` field to construct the asynchronous stack:
           self.coro_frame = coro_frame
           self.resume_func = dereference(self.coro_frame.resume_addr)
           self.resume_func_block = gdb.block_for_pc(self.resume_func)
-          if self.resume_func_block == None:
+          if self.resume_func_block is None:
               raise Exception('Not stackless coroutine.')
           self.line_info = gdb.find_pc_line(self.resume_func)
 
@@ -543,8 +543,8 @@ So we can use the ``continuation`` field to construct the asynchronous stack:
           self.function_name = f
 
       def __str__(self, shift = 2):
-          addr = "" if self.address() == None else '%#x' % self.address() + " in "
-          location = "" if self.filename() == None else " at " + self.filename() + ":" + str(self.line())
+          addr = "" if self.address() is None else '%#x' % self.address() + " in "
+          location = "" if self.filename() is None else " at " + self.filename() + ":" + str(self.line())
           return addr + self.function() + " " + str([str(args) for args in self.frame_args()]) + location
 
   class CoroutineFilter:
@@ -598,7 +598,7 @@ So we can use the ``continuation`` field to construct the asynchronous stack:
 
           addr = int(argv[0], 16)
           block = gdb.block_for_pc(long(cast_addr2long_pointer(addr).dereference()))
-          if block == None:
+          if block is None:
               print "block " + str(addr) + "  is none."
               return
 

diff  --git a/clang/tools/include-mapping/gen_std.py b/clang/tools/include-mapping/gen_std.py
index fcd3bd0d843ea1..f362227bc6aab9 100755
--- a/clang/tools/include-mapping/gen_std.py
+++ b/clang/tools/include-mapping/gen_std.py
@@ -215,7 +215,7 @@ def GetCCompatibilitySymbols(symbol):
     # Introduce two more entries, both in the global namespace, one using the
     # C++-compat header and another using the C header.
     results = []
-    if symbol.namespace != None:
+    if symbol.namespace is not None:
         # avoid printing duplicated entries, for C macros!
         results.append(cppreference_parser.Symbol(symbol.name, None, [header]))
     c_header = "<" + header[2:-1] + ".h>"  # <cstdio> => <stdio.h>

diff  --git a/clang/utils/check_cfc/obj_
diff .py b/clang/utils/check_cfc/obj_
diff .py
index 99ed19e522be20..9d602593a4e1a9 100755
--- a/clang/utils/check_cfc/obj_
diff .py
+++ b/clang/utils/check_cfc/obj_
diff .py
@@ -57,7 +57,7 @@ def first_
diff (a, b, fromfile, tofile):
             first_
diff _idx = idx
             break
 
-    if first_
diff _idx == None:
+    if first_
diff _idx is None:
         # No 
diff erence
         return None
 

diff  --git a/clang/utils/module-deps-to-rsp.py b/clang/utils/module-deps-to-rsp.py
index 6c9f263a786efc..b57a44e5c87809 100755
--- a/clang/utils/module-deps-to-rsp.py
+++ b/clang/utils/module-deps-to-rsp.py
@@ -74,7 +74,7 @@ def main():
 
         if args.module_name:
             cmd = findModule(args.module_name, full_deps)["command-line"]
-        elif args.tu_index != None:
+        elif args.tu_index is not None:
             tu = full_deps.translation_units[args.tu_index]
             cmd = tu["commands"][args.tu_cmd_index]["command-line"]
 


        


More information about the cfe-commits mailing list