[clang] [AST] Iterate redecls starting from the canonical one in getRawCommentsForAnyRedecl() (PR #108475)

Nathan Ridge via cfe-commits cfe-commits at lists.llvm.org
Wed Sep 18 22:49:43 PDT 2024


================
@@ -444,7 +444,7 @@ const RawComment *ASTContext::getRawCommentForAnyRedecl(
     return CommentlessRedeclChains.lookup(CanonicalD);
   }();
 
-  for (const auto Redecl : D->redecls()) {
+  for (const auto Redecl : CanonicalD->redecls()) {
----------------
HighCommander4 wrote:

> regarding `getSourceRange()` relying on `TemplateParameterListsInfo`, which is really peculiar

FWIW, that part actually makes sense to me. For a function/method declaration that looks like this:

```
template <...>
ReturnType FunctionName(Parameters...);
```

the answer to the question "where does the source range begin?" is indeed "if there is a template parameter list, where does it begin?"

https://github.com/llvm/llvm-project/pull/108475


More information about the cfe-commits mailing list