[clang-tools-extra] issue-63565: community requested small QoL fix for more configurabili… (PR #108005)
Nathan Ridge via cfe-commits
cfe-commits at lists.llvm.org
Tue Sep 17 15:27:32 PDT 2024
================
@@ -694,13 +698,20 @@ class FlagsConfigProvider : public config::Provider {
BGPolicy = Config::BackgroundPolicy::Skip;
}
+ if (PlaceholderOption == Config::ArgumentListsOption::Delimiters) {
+ ArgumentLists = PlaceholderOption;
+ }
+
Frag = [=](const config::Params &, Config &C) {
if (CDBSearch)
C.CompileFlags.CDBSearch = *CDBSearch;
if (IndexSpec)
C.Index.External = *IndexSpec;
if (BGPolicy)
C.Index.Background = *BGPolicy;
+ if (ArgumentLists && C.Completion.ArgumentLists ==
----------------
HighCommander4 wrote:
For reasons mentioned above, no need for the second condition here (at this point, the config provider for the config file has not **yet** assigned anything to `C`; when it does run later, it will overwrite the field if needed)
https://github.com/llvm/llvm-project/pull/108005
More information about the cfe-commits
mailing list