[clang] [clang][codegen] Don't mark "int" TBAA on FP libcalls with indirect args (PR #108853)
Benjamin Maxwell via cfe-commits
cfe-commits at lists.llvm.org
Tue Sep 17 08:04:04 PDT 2024
MacDue wrote:
> Not really! `int TBAA` in in our downstream compiler is interpreted as describing the function arguments (they are not int) and the `load/store` of the argument before the library call are begin eliminated which result in unexpected behavior.
> I am not objecting to anything; I am just wondering what difference it makes to have the TBAA attached to the call instead of how it is now.
I believe the intention of both #96025 and #100302 was to set the metadata on the call. The case I mentioned where it was attached to the load after the call just seemed like an unintended consequence of attaching the metadata to the result value.
It sounds like both those changes break your downstream compiler?
https://github.com/llvm/llvm-project/pull/108853
More information about the cfe-commits
mailing list