[clang] [compiler-rt] [llvm] [FMV][AArch64] Unify ls64, ls64_v and ls64_accdata. (PR #108024)
via cfe-commits
cfe-commits at lists.llvm.org
Tue Sep 17 05:14:29 PDT 2024
================
@@ -73,8 +73,6 @@ enum CPUFeatures {
FEAT_SSBS,
FEAT_SSBS2,
FEAT_BTI,
- FEAT_LS64,
- FEAT_LS64_V,
----------------
Wilco1 wrote:
ABI compatibility means you can use different compilers to build object files, link them and they work correctly. If object A uses bit 36, object B uses bit 35 and the runtime uses bit 34, how is it ever going to work?
So using an enum in the implementation is really a bug. The FEAT_xxx bits are defined as constants for a good reason. And yes, these are ABI too!
https://github.com/llvm/llvm-project/pull/108024
More information about the cfe-commits
mailing list