[clang] [clang-tools-extra] Fix OOM in FormatDiagnostic (PR #108187)

Mon Sep 16 08:52:20 PDT 2024

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `premerge-monolithic-linux` running on `premerge-linux-1` while building `clang-tools-extra,clang` at step 6 "build-unified-tree".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/153/builds/9025

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 6 (build-unified-tree) failure: build (failure)
...
367.979 [2905/58/1650] Building CXX object tools/clang/tools/extra/clangd/refactor/tweaks/CMakeFiles/obj.clangDaemonTweaks.dir/ObjCMemberwiseInitializer.cpp.o
367.984 [2904/58/1651] Linking CXX executable bin/llvm-as
368.080 [2903/58/1652] Linking CXX executable bin/llvm-cat
368.096 [2902/58/1653] Linking CXX executable bin/llvm-cgdata
368.130 [2901/58/1654] Linking CXX executable tools/flang/unittests/Evaluate/logical.test
368.156 [2900/58/1655] Linking CXX executable tools/flang/unittests/Evaluate/real.test
368.164 [2899/58/1656] Building CXX object tools/clang/tools/extra/clangd/refactor/tweaks/CMakeFiles/obj.clangDaemonTweaks.dir/ScopifyEnum.cpp.o
368.333 [2898/58/1657] Linking CXX executable tools/flang/unittests/Evaluate/integer.test
368.414 [2897/58/1658] Linking CXX executable bin/llvm-cfi-verify
368.656 [2896/58/1659] Building CXX object tools/flang/lib/Frontend/CMakeFiles/flangFrontend.dir/TextDiagnosticPrinter.cpp.o
FAILED: tools/flang/lib/Frontend/CMakeFiles/flangFrontend.dir/TextDiagnosticPrinter.cpp.o 
CCACHE_CPP2=yes CCACHE_HASHDIR=yes /usr/bin/ccache /usr/bin/clang++ -DFLANG_INCLUDE_TESTS=1 -DFLANG_LITTLE_ENDIAN=1 -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/build/buildbot/premerge-monolithic-linux/build/tools/flang/lib/Frontend -I/build/buildbot/premerge-monolithic-linux/llvm-project/flang/lib/Frontend -I/build/buildbot/premerge-monolithic-linux/llvm-project/flang/include -I/build/buildbot/premerge-monolithic-linux/build/tools/flang/include -I/build/buildbot/premerge-monolithic-linux/build/include -I/build/buildbot/premerge-monolithic-linux/llvm-project/llvm/include -isystem /build/buildbot/premerge-monolithic-linux/llvm-project/llvm/../mlir/include -isystem /build/buildbot/premerge-monolithic-linux/build/tools/mlir/include -isystem /build/buildbot/premerge-monolithic-linux/build/tools/clang/include -isystem /build/buildbot/premerge-monolithic-linux/llvm-project/llvm/../clang/include -gmlt -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -Wno-deprecated-copy -Wno-string-conversion -Wno-ctad-maybe-unsupported -Wno-unused-command-line-argument -Wstring-conversion           -Wcovered-switch-default -Wno-nested-anon-types -O3 -DNDEBUG  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -std=c++17 -MD -MT tools/flang/lib/Frontend/CMakeFiles/flangFrontend.dir/TextDiagnosticPrinter.cpp.o -MF tools/flang/lib/Frontend/CMakeFiles/flangFrontend.dir/TextDiagnosticPrinter.cpp.o.d -o tools/flang/lib/Frontend/CMakeFiles/flangFrontend.dir/TextDiagnosticPrinter.cpp.o -c /build/buildbot/premerge-monolithic-linux/llvm-project/flang/lib/Frontend/TextDiagnosticPrinter.cpp
/build/buildbot/premerge-monolithic-linux/llvm-project/flang/lib/Frontend/TextDiagnosticPrinter.cpp:48:49: error: no member named 'getFlagValue' in 'clang::DiagnosticsEngine'
    llvm::StringRef optValue = info.getDiags()->getFlagValue();
                               ~~~~~~~~~~~~~~~  ^
1 error generated.
368.699 [2896/57/1660] Building CXX object tools/clang/tools/extra/clangd/CMakeFiles/obj.clangDaemon.dir/ParsedAST.cpp.o
368.710 [2896/56/1661] Building CXX object tools/flang/lib/Frontend/CMakeFiles/flangFrontend.dir/TextDiagnostic.cpp.o
368.721 [2896/55/1662] Generating obj.libclc.dir/nvptx--/generic/lib/math/clc_ldexp.cl.bc
368.738 [2896/54/1663] Generating obj.libclc.dir/nvptx--/generic/lib/math/clc_nextafter.cl.bc
368.755 [2896/53/1664] Generating obj.libclc.dir/nvptx--/generic/lib/math/clc_fmod.cl.bc
368.755 [2896/52/1665] Generating obj.libclc.dir/tahiti-amdgcn-mesa-mesa3d/generic/lib/cl_khr_local_int32_base_atomics/atom_add.cl.bc
368.761 [2896/51/1666] Linking CXX executable bin/lli
368.773 [2896/50/1667] Generating obj.libclc.dir/nvptx--/generic/lib/math/clc_hypot.cl.bc
368.775 [2896/49/1668] Linking CXX executable tools/flang/unittests/Evaluate/folding.test
368.987 [2896/48/1669] Building CXX object tools/flang/lib/Frontend/CMakeFiles/flangFrontend.dir/TextDiagnosticBuffer.cpp.o
369.033 [2896/47/1670] Generating obj.libclc.dir/tahiti-amdgcn-mesa-mesa3d/generic/lib/cl_khr_int64_extended_atomics/atom_xor.cl.bc
369.135 [2896/46/1671] Generating obj.libclc.dir/tahiti-amdgcn-mesa-mesa3d/generic/lib/cl_khr_int64_extended_atomics/atom_and.cl.bc
369.161 [2896/45/1672] Building CXX object tools/clang/tools/extra/clangd/refactor/tweaks/CMakeFiles/obj.clangDaemonTweaks.dir/SwapIfBranches.cpp.o
369.169 [2896/44/1673] Building CXX object tools/clang/tools/libclang/CMakeFiles/libclang.dir/CXSourceLocation.cpp.o
369.279 [2896/43/1674] Linking CXX executable bin/fir-opt
369.306 [2896/42/1675] Linking CXX executable bin/llc
369.307 [2896/41/1676] Linking CXX executable bin/dsymutil
369.323 [2896/40/1677] Generating obj.libclc.dir/nvptx--/generic/lib/math/clc_pow.cl.bc
369.467 [2896/39/1678] Building CXX object tools/clang/tools/extra/test/CMakeFiles/CTTestTidyModule.dir/clang-tidy/CTTestTidyModule.cpp.o
369.502 [2896/38/1679] Building CXX object tools/clang/tools/libclang/CMakeFiles/libclang.dir/CXStoredDiagnostic.cpp.o
369.533 [2896/37/1680] Building CXX object tools/clang/tools/libclang/CMakeFiles/libclang.dir/CXString.cpp.o
369.550 [2896/36/1681] Linking CXX executable bin/llvm-c-test
369.870 [2896/35/1682] Building CXX object tools/bolt/lib/Utils/CMakeFiles/LLVMBOLTUtils.dir/CommandLineOpts.cpp.o
369.898 [2896/34/1683] Building CXX object tools/clang/tools/libclang/CMakeFiles/libclang.dir/CXCursor.cpp.o
370.026 [2896/33/1684] Building CXX object tools/clang/tools/libclang/CMakeFiles/libclang.dir/Rewrite.cpp.o
370.120 [2896/32/1685] Building CXX object tools/clang/tools/extra/clangd/CMakeFiles/obj.clangDaemon.dir/ClangdLSPServer.cpp.o
370.190 [2896/31/1686] Building CXX object tools/clang/tools/extra/clangd/fuzzer/CMakeFiles/clangd-fuzzer.dir/clangd-fuzzer.cpp.o
370.411 [2896/30/1687] Building CXX object tools/clang/tools/extra/clangd/refactor/tweaks/CMakeFiles/obj.clangDaemonTweaks.dir/SpecialMembers.cpp.o
370.512 [2896/29/1688] Generating obj.libclc.dir/clspv64--/clspv-convert.cl.bc
370.765 [2896/28/1689] Building CXX object tools/clang/tools/extra/clangd/index/dex/dexp/CMakeFiles/dexp.dir/Dexp.cpp.o
370.853 [2896/27/1690] Generating obj.libclc.dir/clspv--/clspv-convert.cl.bc
370.921 [2896/26/1691] Building CXX object tools/clang/tools/libclang/CMakeFiles/libclang.dir/CIndexCodeCompletion.cpp.o
370.922 [2896/25/1692] Building CXX object tools/clang/tools/libclang/CMakeFiles/libclang.dir/CXType.cpp.o

```

</details>

https://github.com/llvm/llvm-project/pull/108187