[clang-tools-extra] issue-63565: community requested small QoL fix for more configurabili… (PR #108005)

via cfe-commits cfe-commits at lists.llvm.org
Sat Sep 14 11:04:21 PDT 2024


MK-Alias wrote:

Updated the source. It should now confirm to everything. To recap: `.clangd` now has a added key: `ArgumentLists` in the `Completion` block. It supports these values: `None` | `OpenDelimiter` | `Delimiters` | `FullPlaceholders`. The `.clangd` config will overwite the prevously used: `--function-arg-placeholders`, which means that the only effect still done by `--function-arg-placeholders=0`, is when `.clangd` has no `ArgumentLists` value. In which case it will use the `Delimiters`.

UnitTest have also been updated. Other then the tests already in place, it will also check the `None` option and the `OpenDelimiter` option. The `FullPlaceholders` option is not checked. It was also never checked prior to this patch.

As mentions in [this post](https://github.com/llvm/llvm-project/issues/63565#issuecomment-2337396222): these to issues remain within vsocde/vscode-clangd:

- None: after completion an error squiggly line will occur on the identifier. Would be slightly nicer if it wouldn't.
- OpenDelimiter: the signature help hover doesn't spawn. It seems that [Sam's Patch from #398](https://github.com/clangd/vscode-clangd/pull/398/files) needs to be reconfigured for this.

The OpenDelimiter issue seems like a small fix and would generally improve the UX on this. 
    

Ill be awaiting your response.

https://github.com/llvm/llvm-project/pull/108005


More information about the cfe-commits mailing list