[clang] [HLSL] Add `[[hlsl::contained_type()]]` attribute (PR #108456)

Justin Bogner via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 12 14:50:55 PDT 2024


================
@@ -30,9 +31,9 @@ class Scope;
 
 // FIXME: This can be hidden (as static function in SemaHLSL.cpp) once we no
 // longer need to create builtin buffer types in HLSLExternalSemaSource.
-bool CreateHLSLAttributedResourceType(Sema &S, QualType Wrapped,
-                                      ArrayRef<const Attr *> AttrList,
-                                      QualType &ResType);
+bool CreateHLSLAttributedResourceType(
+    Sema &S, QualType Wrapped, ArrayRef<const Attr *> AttrList,
+    QualType &ResType, HLSLAttributedResourceLocInfo *LocInfo = nullptr);
----------------
bogner wrote:

Do we actually need the `HLSLAttributedResourceLocInfo` to be defaulted/nullable? Can it just be a reference instead?

https://github.com/llvm/llvm-project/pull/108456


More information about the cfe-commits mailing list