[clang] [clang-tools-extra] [clang] Extend diagnose_if to accept more detailed warning information (PR #70976)

Nikolas Klauser via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 12 02:28:31 PDT 2024


================
@@ -870,7 +872,8 @@ class DiagnosticsEngine : public RefCountedBase<DiagnosticsEngine> {
   /// \param FormatString A fixed diagnostic format string that will be hashed
   /// and mapped to a unique DiagID.
   template <unsigned N>
-  unsigned getCustomDiagID(Level L, const char (&FormatString)[N]) {
+  [[deprecated("Use a CustomDiagDesc instead of a Level")]] unsigned
----------------
philnik777 wrote:

I guess so. Should we maybe enable `-Werror` in the pre-commit CI to catch these kinds of problems?

https://github.com/llvm/llvm-project/pull/70976


More information about the cfe-commits mailing list