[clang] [llvm] Add step builtins and step HLSL function to DirectX and SPIR-V backend (PR #106471)

via cfe-commits cfe-commits at lists.llvm.org
Wed Sep 11 16:26:21 PDT 2024


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff 93e45a69dde16e6a3ac0ddbcc596ac3843d59c43 7924bab45ce0436eb71a8548fe35f4d79594d00f --extensions cpp,h -- clang/lib/CodeGen/CGBuiltin.cpp clang/lib/CodeGen/CGHLSLRuntime.h clang/lib/Headers/hlsl/hlsl_intrinsics.h clang/lib/Sema/SemaHLSL.cpp llvm/lib/Target/DirectX/DXILIntrinsicExpansion.cpp llvm/lib/Target/SPIRV/SPIRVInstructionSelector.cpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/llvm/lib/Target/DirectX/DXILIntrinsicExpansion.cpp b/llvm/lib/Target/DirectX/DXILIntrinsicExpansion.cpp
index 8ec36103cc..c22b43977f 100644
--- a/llvm/lib/Target/DirectX/DXILIntrinsicExpansion.cpp
+++ b/llvm/lib/Target/DirectX/DXILIntrinsicExpansion.cpp
@@ -452,13 +452,13 @@ static bool expandIntrinsic(Function &F, CallInst *Orig) {
   case Intrinsic::dx_sdot:
   case Intrinsic::dx_udot:
     Result = expandIntegerDotIntrinsic(Orig, IntrinsicId);
-    break;  
+    break;
   case Intrinsic::dx_sign:
     Result = expandSignIntrinsic(Orig);
     break;
   }
-  case Intrinsic::dx_step:
-    Result = expandStepIntrinsic(Orig);
+case Intrinsic::dx_step:
+  Result = expandStepIntrinsic(Orig);
   if (Result) {
     Orig->replaceAllUsesWith(Result);
     Orig->eraseFromParent();
diff --git a/llvm/lib/Target/SPIRV/SPIRVInstructionSelector.cpp b/llvm/lib/Target/SPIRV/SPIRVInstructionSelector.cpp
index 65526b4096..b526c9f29f 100644
--- a/llvm/lib/Target/SPIRV/SPIRVInstructionSelector.cpp
+++ b/llvm/lib/Target/SPIRV/SPIRVInstructionSelector.cpp
@@ -1667,7 +1667,6 @@ bool SPIRVInstructionSelector::selectSaturate(Register ResVReg,
       .constrainAllUses(TII, TRI, RBI);
 }
 
-
 bool SPIRVInstructionSelector::selectSign(Register ResVReg,
                                           const SPIRVType *ResType,
                                           MachineInstr &I) const {

``````````

</details>


https://github.com/llvm/llvm-project/pull/106471


More information about the cfe-commits mailing list