[clang] nonblocking/nonallocating attributes: 2nd pass caller/callee analysis (PR #99656)

[Erich Keane via cfe-commits]

================
@@ -8392,6 +8397,20 @@ void ASTReader::InitializeSema(Sema &S) {
         NewOverrides.applyOverrides(SemaObj->getLangOpts());
   }
 
+  if (!DeclsWithEffectsToVerify.empty()) {
+    for (GlobalDeclID ID : DeclsWithEffectsToVerify) {
+      Decl *D = GetDecl(ID);
+      FunctionEffectsRef FX;
+      if (auto *FD = dyn_cast<FunctionDecl>(D))
+        FX = FD->getFunctionEffects();
+      else if (auto *BD = dyn_cast<BlockDecl>(D))
+        FX = BD->getFunctionEffects();
----------------
erichkeane wrote:

Since the list only has 2, I'd probably just do the `addDeclWithEffects` call in each of these 'if' statements.

https://github.com/llvm/llvm-project/pull/99656