[clang] [Clang] [Draft] Implement P0588R1 capture rules (PR #105953)
Richard Smith via cfe-commits
cfe-commits at lists.llvm.org
Wed Sep 4 10:10:42 PDT 2024
================
@@ -281,7 +283,115 @@ namespace {
return inherited::TraverseLambdaCapture(Lambda, C, Init);
}
};
-}
+
+
+ class CollectExpandedParameterPacksVisitor
----------------
zygoloid wrote:
As a general concern, I think various parts of our pack handling would be cleaner if the parser tracked the set of packs used in a pack expandable region and annotated them on the pack expansion construct, rather than recursively walking the AST to reconstruct the list after the fact. (The latter is working, but it's fragile and we've had various bugs with the walk not quite finding everything for various reasons. It's also inefficient to walk the complete expanded region to search for the packs -- but given that we'll need to do that walk anyway when we actually expand, it's not asymptotically bad, except in the case where the packs are empty.)
https://github.com/llvm/llvm-project/pull/105953
More information about the cfe-commits
mailing list