[clang] [Clang][Sema] Use the correct lookup context when building overloaded 'operator->' in the current instantiation (PR #104458)

via cfe-commits cfe-commits at lists.llvm.org
Tue Sep 3 08:15:45 PDT 2024


================
@@ -7939,7 +7927,14 @@ ExprResult Sema::ActOnStartCXXMemberReference(Scope *S, Expr *Base,
           }
         }
         return ExprError();
+      } else if (Result.isUnset()) {
+        // BuildOverloadedArrowExpr returns an empty expression to indicate
+        // that we need to build a dependent overloaded arrow expression.
----------------
cor3ntin wrote:

I have 2 concerns with that
 1/ It's a bit too clever of an interface
 2/ We should make sure this can only happens in Sema, right? I wonder if we need an ActOnOverloadedArrowExpr to wrap that logic such that (it would duplicate the lookup code but i think that's a better outcome)

WDYT?

https://github.com/llvm/llvm-project/pull/104458


More information about the cfe-commits mailing list