[clang] [RFC][C++20][Modules] Fix crash when function and lambda inside loaded from different modules (PR #104512)

Chuanqi Xu via cfe-commits cfe-commits at lists.llvm.org
Mon Sep 2 19:32:30 PDT 2024


Valentin Clement =?utf-8?b?KOODkOODrOODsw=?=,Kyungwoo Lee <kyulee at meta.com>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/104512 at github.com>


ChuanqiXu9 wrote:

> > I am curious about your real project, is it open source?
> 
> Unfortunately, it is not an open source project but we use bunch of OSS libraries like Folly, Thrift and many other so I see bugs that cannot be easily minimized and reproduced. I added test-case for the crash I observe (now asserts happens in different place but it is the same root cause that I changed order of lambda deserialization). I'm still working on a fix.

Got it. I am pretty interested use case for modules. And from your commit history, it looks like you prefer header units than named modules?

https://github.com/llvm/llvm-project/pull/104512


More information about the cfe-commits mailing list