[clang-tools-extra] [NFC][clang-tidy] fix tests of deleted functions for missing-std-forward (PR #106861)
Julian Schmidt via cfe-commits
cfe-commits at lists.llvm.org
Sat Aug 31 09:35:51 PDT 2024
https://github.com/5chmidti created https://github.com/llvm/llvm-project/pull/106861
Since #87832, unnamed identifiers are excluded from being diagnosed. As
a result, the tests that were supposed to test that deleted functions
are correctly ignored are ignored because of the unnamed identifiers
instead of the deleted function. This change simply introduces names for
the parameters of the deleted functions.
>From a842ba55308b7790a17ed85a84fc83863577662e Mon Sep 17 00:00:00 2001
From: Julian Schmidt <git.julian.schmidt at gmail.com>
Date: Sat, 31 Aug 2024 18:30:03 +0200
Subject: [PATCH] [NFC][clang-tidy] fix tests of deleted functions for
missing-std-forward
Since #87832, unnamed identifiers are excluded from being diagnosed. As
a result, the tests that were supposed to test that deleted functions
are correctly ignored are ignored because of the unnamed identifiers
instead of the deleted function. This change simply introduces names for
the parameters of the deleted functions.
---
.../checkers/cppcoreguidelines/missing-std-forward.cpp | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/missing-std-forward.cpp b/clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/missing-std-forward.cpp
index 8116db58c937d4..98c592db7ce226 100644
--- a/clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/missing-std-forward.cpp
+++ b/clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/missing-std-forward.cpp
@@ -187,14 +187,14 @@ void lambda_value_reference_auxiliary_var(T&& t) {
namespace deleted_functions {
template <typename T>
-void f(T &&) = delete;
+void f(T &&t) = delete;
struct S {
template <typename T>
- S(T &&) = delete;
+ S(T &&t) = delete;
template <typename T>
- void operator&(T &&) = delete;
+ void operator&(T &&t) = delete;
};
} // namespace deleted_functions
More information about the cfe-commits
mailing list