[clang] [HLSL] Add testing for space parameter on global constants (PR #106782)

Damyan Pepper via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 30 19:52:20 PDT 2024


================
@@ -722,7 +722,8 @@ static void ValidateMultipleRegisterAnnotations(Sema &S, Decl *TheDecl,
 }
 
 static void DiagnoseHLSLRegisterAttribute(Sema &S, SourceLocation &ArgLoc,
-                                          Decl *TheDecl, RegisterType regType) {
+                                          Decl *TheDecl, RegisterType regType,
+                                          const ParsedAttr &AL) {
----------------
damyanp wrote:

I wonder if this might read more cleanly if the last parameter was `bool SpecifiedSpace` or similar.

https://github.com/llvm/llvm-project/pull/106782


More information about the cfe-commits mailing list