[clang] [HLSL] Add testing for space parameter on global constants (PR #106782)

[Damyan Pepper via cfe-commits]

================
@@ -817,8 +821,12 @@ static void DiagnoseHLSLRegisterAttribute(Sema &S, SourceLocation &ArgLoc,
       S.Diag(TheDecl->getLocation(),
              diag::warn_hlsl_user_defined_type_missing_member)
           << regTypeNum;
-
-    return;
+    // Space argument cannot be specified for global constants
+    if (!isDeclaredWithinCOrTBuffer(TheDecl)) {
----------------
damyanp wrote:

What's the `!isDeclaredWithinCOrTBuffer()` test for?  If I comment that out then the tests still pass.

https://github.com/llvm/llvm-project/pull/106782