[clang] [llvm] [SCCP] Infer return attributes in SCCP as well (PR #106732)

via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 30 10:31:00 PDT 2024


================
@@ -354,6 +354,36 @@ bool SCCPSolver::removeNonFeasibleEdges(BasicBlock *BB, DomTreeUpdater &DTU,
   return true;
 }
 
+void SCCPSolver::inferReturnAttributes() const {
+  for (const auto &I : getTrackedRetVals()) {
+    Function *F = I.first;
+    const ValueLatticeElement &ReturnValue = I.second;
+
+    // If there is a known constant range for the return value, add range
+    // attribute to the return value.
+    if (ReturnValue.isConstantRange() &&
+        !ReturnValue.getConstantRange().isSingleElement()) {
+      // Do not add range metadata if the return value may include undef.
----------------
goldsteinn wrote:

I don't see any tests for this.

Is the reason for this to avoid creating UB where we where just propagating poison beforehand? If so, do you also need `noundef` for propagating `nonnull`?

https://github.com/llvm/llvm-project/pull/106732


More information about the cfe-commits mailing list