[clang] [llvm] target ABI: improve call parameters extensions handling (PR #100757)

Nikita Popov via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 30 05:48:10 PDT 2024


nikic wrote:

> Patch updated per @nikic suggestion to use a TargetOption flag to simply disable this for llc.
> 
> With all the llc lit tests out of the way, I now see:
> 
>   * 1 test failing in CodeGenObjC
> 
>   * failing tests in clang/test/Interpreter
> 
>   * failing tetss in llvm/test/ExecutionEngine/Orc/./OrcJITTests.
> 
> 
> Not sure if these tools should also "do their job" and actually be fixed, like clang? Or are these also llc-like in the sense that they are only used internally by llvm developers? For the Objective-C test, not sure if this maybe could be disabled for SystemZ at least?

A bit hard to say without more information, but I think all of these should be fixed. Even if ObjC isn't really a thing on s390x, the root cause is probably legitimate (something emitting arguments without going through the proper API?)

https://github.com/llvm/llvm-project/pull/100757


More information about the cfe-commits mailing list