[clang] [analyzer] Refactor MallocChecker to use `BindExpr` in `evalCall` (PR #106081)

DonĂ¡t Nagy via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 30 03:57:58 PDT 2024


NagyDonat wrote:

> To me, a switch from eval-call to post-call should be NFC for the most part.

Minor correction: this commit switches from post-call to eval-call, not the other way around.

> It would be nice if we could separate out that NFC part in a PR, and then deal with the breaking changes in a limited PR.

The "main" part of this change (the actual post-call -> eval-call switch) is close to being NFC, but is not exactly an NFC because there are subtle differences between the two callback kinds. It would be possible to move a few minor cleanup changes (e.g. the removal of the superfluous argument of `setDynamicExtent` or the correction of the return type of `getConjuredHeapSymbolVal`) into a separate NFC commit but I'm not sure that the reorganization effort is worth it.


https://github.com/llvm/llvm-project/pull/106081


More information about the cfe-commits mailing list