[clang] [clang] Properly set file and line info for -ftime-trace (PR #106277)

Ilya Biryukov via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 28 02:29:47 PDT 2024


================
@@ -1255,8 +1256,12 @@ Parser::DeclGroupPtrTy Parser::ParseDeclarationOrFunctionDefinition(
   // Add an enclosing time trace scope for a bunch of small scopes with
   // "EvaluateAsConstExpr".
   llvm::TimeTraceScope TimeScope("ParseDeclarationOrFunctionDefinition", [&]() {
-    return Tok.getLocation().printToString(
-        Actions.getASTContext().getSourceManager());
+    llvm::TimeTraceMetadata M;
----------------
ilya-biryukov wrote:

The column might be a little redundant for functions, but may be useful for other events to help identify them.
Should we add it now? Are there any downsides to adding it?

https://github.com/llvm/llvm-project/pull/106277


More information about the cfe-commits mailing list