[clang] [BoundsSafety][Sema] Allow counted_by and counted_by_or_null on pointers where the pointee type is incomplete but potentially completable (PR #106321)

Dan Liew via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 28 01:18:04 PDT 2024


================
@@ -2099,6 +2099,70 @@ class Sema final : public SemaBase {
   bool CheckCountedByAttrOnField(FieldDecl *FD, Expr *E, bool CountInBytes,
                                  bool OrNull);
 
+  // AssignmentAction - This is used by all the assignment diagnostic functions
+  // to represent what is actually causing the operation
+  enum AssignmentAction {
----------------
delcypher wrote:

@Endilll Any opinions on where `AssignmentAction` should go? Unfortunately I had to move it because the enum needs to be defined before I can use it as a parameter type.

This wasn't a problem in the original version of my patch but when I rebased on latest `next` it appears a recent refactor (9f1dc01e0ab4f91c4052a712ce590d2e86b81dc3) moved where the `BoundsSafety*` methods are declared so that they are now **before** where `AssignmentAction`'s declaration. Previously the methods were declared after `AssignmentActions`'s declaration.

https://github.com/llvm/llvm-project/pull/106321


More information about the cfe-commits mailing list