[clang] 6e44cb3 - [analyzer][NFC] Remove a non-actionable dump (#106232)

[via cfe-commits]

Author: Arseniy Zaostrovnykh
Date: 2024-08-27T17:38:07+02:00
New Revision: 6e44cb3ccb822085cd2f35c63daa60395dda26f2

URL: https://github.com/llvm/llvm-project/commit/6e44cb3ccb822085cd2f35c63daa60395dda26f2
DIFF: https://github.com/llvm/llvm-project/commit/6e44cb3ccb822085cd2f35c63daa60395dda26f2.diff

LOG: [analyzer][NFC] Remove a non-actionable dump (#106232)

This dump, if it is ever executed, is not actionable by the user and
might produce unwanted noise in the stderr.

The original intention behind this dump, to provide maximum information
in an unexpected situation, does not outweigh the potential annoyance
caused to users who might not even realize that they witnessed an
unexpected situation.

Added: 
    

Modified: 
    clang/lib/StaticAnalyzer/Checkers/StackAddrEscapeChecker.cpp

Removed: 
    


################################################################################
diff  --git a/clang/lib/StaticAnalyzer/Checkers/StackAddrEscapeChecker.cpp b/clang/lib/StaticAnalyzer/Checkers/StackAddrEscapeChecker.cpp
index dcf6801a73de2d..cdbede6981aa09 100644
--- a/clang/lib/StaticAnalyzer/Checkers/StackAddrEscapeChecker.cpp
+++ b/clang/lib/StaticAnalyzer/Checkers/StackAddrEscapeChecker.cpp
@@ -326,7 +326,6 @@ std::optional<std::string> printReferrer(const MemRegion *Referrer) {
       // warn_init_ptr_member_to_parameter_addr
       return std::nullopt;
     } else {
-      Referrer->dump();
       assert(false && "Unexpected referrer region type.");
       return std::nullopt;
     }