[clang] [analyzer][NFC] Remove a non-actionable dump (PR #106232)

[Arseniy Zaostrovnykh via cfe-commits]

https://github.com/necto created https://github.com/llvm/llvm-project/pull/106232

This dump, if it is ever executed, is not actionable by the user and might produce unwanted noise in the stderr.

The original intention behind this dump, to provide maximum information in an unexpected situation, does not outweigh the potential annoyance caused to users who might not even realize that they witnessed an unexpected situation.

>From 3daf20657c7e87f24595fbcca530c539b6d13cf6 Mon Sep 17 00:00:00 2001
From: Arseniy Zaostrovnykh <necto.ne at gmail.com>
Date: Tue, 27 Aug 2024 16:51:59 +0200
Subject: [PATCH] [analyzer][NFC] Remove a non-actionable dump

---
 clang/lib/StaticAnalyzer/Checkers/StackAddrEscapeChecker.cpp | 1 -
 1 file changed, 1 deletion(-)

diff --git a/clang/lib/StaticAnalyzer/Checkers/StackAddrEscapeChecker.cpp b/clang/lib/StaticAnalyzer/Checkers/StackAddrEscapeChecker.cpp
index dcf6801a73de2d..cdbede6981aa09 100644
--- a/clang/lib/StaticAnalyzer/Checkers/StackAddrEscapeChecker.cpp
+++ b/clang/lib/StaticAnalyzer/Checkers/StackAddrEscapeChecker.cpp
@@ -326,7 +326,6 @@ std::optional<std::string> printReferrer(const MemRegion *Referrer) {
       // warn_init_ptr_member_to_parameter_addr
       return std::nullopt;
     } else {
-      Referrer->dump();
       assert(false && "Unexpected referrer region type.");
       return std::nullopt;
     }