[clang] [llvm] Tentative fix for not removing newly internal functions (PR #106146)
via cfe-commits
cfe-commits at lists.llvm.org
Mon Aug 26 14:42:13 PDT 2024
github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git-clang-format --diff 85561dd59485350a4f09ea5cb049b38f69b1e470 6cf9e802a47860279fc793cb07ac3f4850826cb3 --extensions cpp -- llvm/lib/Target/DirectX/DXILFinalizeLinkage.cpp
``````````
</details>
<details>
<summary>
View the diff from clang-format here.
</summary>
``````````diff
diff --git a/llvm/lib/Target/DirectX/DXILFinalizeLinkage.cpp b/llvm/lib/Target/DirectX/DXILFinalizeLinkage.cpp
index 6508258cdd..0055ad3073 100644
--- a/llvm/lib/Target/DirectX/DXILFinalizeLinkage.cpp
+++ b/llvm/lib/Target/DirectX/DXILFinalizeLinkage.cpp
@@ -31,7 +31,7 @@ static bool finalizeLinkage(Module &M) {
if (F->getLinkage() == GlobalValue::ExternalLinkage) {
F->setLinkage(GlobalValue::InternalLinkage);
if (F->isDefTriviallyDead())
- M.getFunctionList().erase(F);
+ M.getFunctionList().erase(F);
}
}
``````````
</details>
https://github.com/llvm/llvm-project/pull/106146
More information about the cfe-commits
mailing list