[clang] [DXIL] Don't generate per-variable guards for DirectX (PR #106096)
Damyan Pepper via cfe-commits
cfe-commits at lists.llvm.org
Mon Aug 26 09:13:39 PDT 2024
================
@@ -0,0 +1,37 @@
+// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.0-compute -emit-llvm -o - -disable-llvm-passes %s | FileCheck %s
+
+// Verify that no per variable _Init_thread instructions are emitted for non-trivial static locals
+// These would normally be emitted by the MicrosoftCXXABI, but the DirectX backend should exlude them
+// Instead, check for the guardvar oparations that should protect the constructor initialization should
+// only take place once.
+
+RWBuffer<int> buf[10];
+
+void InitBuf(RWBuffer<int> buf) {
+ for (unsigned i; i < 100; i++)
+ buf[i] = 0;
+}
+
+// CHECK-NOT: _Init_thread_epoch
+// CHECK: define internal void @"?main@@YAXXZ"
+// CHECK-NEXT: entry:
+// CHECK-NEXT: [[Tmp1:%.*]] = alloca %"class.hlsl::RWBuffer"
+// CHECK-NEXT: [[Tmp2:%.*]] = load i32, ptr
+// CHECK-NEXT: [[Tmp3:%.*]] = and i32 [[Tmp2]], 1
+// CHECK-NEXT: [[Tmp4:%.*]] = icmp eq i32 [[Tmp3]], 0
+// CHECK-NEXT: br i1 [[Tmp4]]
+// CHECK-NOT: _Init_thread_header
+// CHECK: init:
+// CHECK-NEXT: = or i32 [[Tmp2]], 1
+// CHECK-NOT: _Init_thread_footer
+
+
+[shader("compute")]
+[numthreads(1,1,1)]
+void main() {
+ // A non-trivially initialized static local will get checks to verify that it is generated just once
+ static RWBuffer<int> mybuf;
+ mybuf = buf[0];
----------------
damyanp wrote:
Testing my C++ language details to the limit here...but isn't `myBuf` default constructed, and then assigned to `buf[0]`? Would this be actually initializing it?
```c++
static RWBuffer<int> myBuf = buf[0]
```
https://github.com/llvm/llvm-project/pull/106096
More information about the cfe-commits
mailing list