[clang] [Clang][Concepts] Fix the constraint equivalence checking involving parameter packs (PR #102131)

via cfe-commits cfe-commits at lists.llvm.org
Sun Aug 25 22:52:34 PDT 2024


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff 3364284d87035eaac9662d345d4ddee2714f8fd7 811bfc9011adf48bb22cce3e0ece0f7539bd095c --extensions cpp -- clang/lib/Sema/SemaConcept.cpp clang/test/SemaTemplate/concepts-out-of-line-def.cpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/clang/lib/Sema/SemaConcept.cpp b/clang/lib/Sema/SemaConcept.cpp
index 6e31cc6f87..1b8fd5bf70 100644
--- a/clang/lib/Sema/SemaConcept.cpp
+++ b/clang/lib/Sema/SemaConcept.cpp
@@ -983,10 +983,10 @@ static const Expr *SubstituteConstraintExpressionWithoutSatisfaction(
       // otherwise reference the AssociatedDecl of the template arguments, which
       // is, in this case, the template declaration.
       //
-      // However, as we are in the process of comparing potential re-declarations,
-      // the canonical declaration is the declaration itself at this point.
-      // moment. So if we didn't expand these packs, we would end up with an
-      // incorrect profile difference because we will be profiling the
+      // However, as we are in the process of comparing potential
+      // re-declarations, the canonical declaration is the declaration itself at
+      // this point. moment. So if we didn't expand these packs, we would end up
+      // with an incorrect profile difference because we will be profiling the
       // canonical types!
       //
       // FIXME: Improve the "no-transform" machinery in FindInstantiatedDecl so

``````````

</details>


https://github.com/llvm/llvm-project/pull/102131


More information about the cfe-commits mailing list