[clang-tools-extra] [clang-tidy] Update TODO comment check (PR #104868)

Alan Rosenthal via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 22 15:07:44 PDT 2024


================
@@ -45,7 +54,7 @@ class TodoCommentCheck::TodoCommentHandler : public CommentHandler {
 private:
   TodoCommentCheck &Check;
   std::string User;
-  llvm::Regex TodoMatch;
+  std::list<std::string> TodoMatches;
----------------
AlanRosenthal wrote:

Hi @njames93, thanks for the review. I've updated the PR to initialize the regexes in the constructor.

I had thought about combining the regex, but I had concluded that it would make it very difficult to read / update / maintain.

Please take a look at the current version, thanks!

https://github.com/llvm/llvm-project/pull/104868


More information about the cfe-commits mailing list