[clang] [clang-format] Don't insert a space between :: and * (PR #105043)

Owen Pan via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 22 02:30:15 PDT 2024


================
@@ -4589,9 +4589,12 @@ bool TokenAnnotator::spaceRequiredBetween(const AnnotatedLine &Line,
     if (!BeforeLeft)
       return false;
     if (BeforeLeft->is(tok::coloncolon)) {
-      const auto *Prev = BeforeLeft->Previous;
-      return Left.is(tok::star) && Prev &&
-             !Prev->endsSequence(tok::identifier, TT_FunctionTypeLParen);
+      if (Left.isNot(tok::star))
+        return false;
+      if (!Right.startsSequence(tok::identifier, tok::r_paren))
+        return true;
+      const auto *Tok = Right.Next->MatchingParen;
----------------
owenca wrote:

No, because `startsSequence()` returned `true`. I'll add an assertion though.

https://github.com/llvm/llvm-project/pull/105043


More information about the cfe-commits mailing list