[libunwind] [libunwind] Stop installing the mach-o module map (PR #105616)

via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 21 22:33:03 PDT 2024


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-libunwind

Author: Ian Anderson (ian-twilightcoder)

<details>
<summary>Changes</summary>

libunwind shouldn't know that compact_unwind_encoding.h is part of a MachO module that it doesn't own. Delete the mach-o module map, and let whatever is in charge of the mach-o directory be the one to say how its module is organized and where compact_unwind_encoding.h fits in.

---
Full diff: https://github.com/llvm/llvm-project/pull/105616.diff


2 Files Affected:

- (modified) libunwind/include/CMakeLists.txt (-1) 
- (removed) libunwind/include/mach-o/compact_unwind_encoding.modulemap (-4) 


``````````diff
diff --git a/libunwind/include/CMakeLists.txt b/libunwind/include/CMakeLists.txt
index 51065d68afd4ea..6796d67a3354ff 100644
--- a/libunwind/include/CMakeLists.txt
+++ b/libunwind/include/CMakeLists.txt
@@ -3,7 +3,6 @@ set(files
     libunwind.h
     libunwind.modulemap
     mach-o/compact_unwind_encoding.h
-    mach-o/compact_unwind_encoding.modulemap
     unwind_arm_ehabi.h
     unwind_itanium.h
     unwind.h
diff --git a/libunwind/include/mach-o/compact_unwind_encoding.modulemap b/libunwind/include/mach-o/compact_unwind_encoding.modulemap
deleted file mode 100644
index 6eae657d31b5c5..00000000000000
--- a/libunwind/include/mach-o/compact_unwind_encoding.modulemap
+++ /dev/null
@@ -1,4 +0,0 @@
-module MachO.compact_unwind_encoding [system] {
-  header "compact_unwind_encoding.h"
-  export *
-}

``````````

</details>


https://github.com/llvm/llvm-project/pull/105616


More information about the cfe-commits mailing list