[clang] [Clang] Overflow Pattern Exclusions (PR #100272)
Justin Stitt via cfe-commits
cfe-commits at lists.llvm.org
Wed Aug 21 09:57:12 PDT 2024
JustinStitt wrote:
@nico
> The test added here was tweaked a bit and then deleted in [07a8cba](https://github.com/llvm/llvm-project/commit/07a8cbaf8dc16bebf6e875173d20299d9cc47cc5)
>
> What gives?
>
> Instead of deleting tests, we should revert the PR that adds them and then reland the PR with working tests.
The tests are back under a new name https://github.com/llvm/llvm-project/pull/104889/files
And if you're mentioning specifically the tests involving `ZSTD` kernel code, those were removed. Not because they failed or caused build issues but because they are now obsolete and were simply remnants of a time when these pattern exclusions were implemented as an IR optimization pass -- also there was some licensing issues with using un-minimized kernel code in the tests so instead of obfuscating them I just removed them.
tl;dr: there's still tests but I removed one single edge case test that is obsolete.
https://github.com/llvm/llvm-project/pull/100272
More information about the cfe-commits
mailing list