[clang] [clang] Merge lifetimebound and GSL code paths for lifetime analysis (PR #104906)

[Utkarsh Saxena via cfe-commits]

================
@@ -439,6 +378,8 @@ static void visitLifetimeBoundArguments(IndirectLocalPath &Path, Expr *Call,
   if (!Callee)
     return;
 
+  bool EnableGSLAnalysis = !Callee->getASTContext().getDiagnostics().isIgnored(
----------------
usx95 wrote:

Can we move this to `VisitGSLPointerArg` and do all the calls to it unconditionally ?
This would remove the 3–4 usages in `if` conditions as well.

FWIW, I don't think this would effect performance with a few extra calls, as it only exists for optionally turning this analysis off.

https://github.com/llvm/llvm-project/pull/104906