[clang] [Clang][NFCI] Cleanup the fix for default function argument substitution (PR #104911)
Younan Zhang via cfe-commits
cfe-commits at lists.llvm.org
Tue Aug 20 04:00:54 PDT 2024
================
@@ -285,7 +286,8 @@ Response HandleFunction(Sema &SemaRef, const FunctionDecl *Function,
// If this function was instantiated from a specialized member that is
// a function template, we're done.
assert(Function->getPrimaryTemplate() && "No function template?");
- if (Function->getPrimaryTemplate()->isMemberSpecialization())
+ if (!ForDefaultArgumentSubstitution &&
+ Function->getPrimaryTemplate()->isMemberSpecialization())
----------------
zyn0217 wrote:
An alternative is to use `(ForConstraintInstantiation || !RelativeToPrimary)` so we could get rid of the usages for concepts where it expects an end after a member specialization. But I feel like that makes the semantics of the flags vague, so ideas are welcome here.
https://github.com/llvm/llvm-project/pull/104911
More information about the cfe-commits
mailing list