[clang] [clang][ExtractAPI] Stop dropping fields of nested anonymous record types when they aren't attached to variable declaration (PR #104600)

Mon Aug 19 08:48:02 PDT 2024

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `lldb-aarch64-windows` running on `linaro-armv8-windows-msvc-05` while building `clang` at step 4 "build".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/141/builds/1687

Here is the relevant piece of the build log for the reference:
```
Step 4 (build) failure: build (failure)
...
565.928 [501/10/5868] Building CXX object tools\bugpoint\CMakeFiles\bugpoint.dir\FindBugs.cpp.obj
565.936 [500/10/5869] Building CXX object tools\bugpoint\CMakeFiles\bugpoint.dir\ExecutionDriver.cpp.obj
566.012 [499/10/5870] Building CXX object tools\bugpoint\CMakeFiles\bugpoint.dir\Miscompilation.cpp.obj
566.042 [498/10/5871] Building CXX object tools\bugpoint\CMakeFiles\bugpoint.dir\OptimizerDriver.cpp.obj
566.186 [497/10/5872] Building CXX object tools\bugpoint\CMakeFiles\bugpoint.dir\ToolRunner.cpp.obj
566.223 [496/10/5873] Building CXX object tools\dsymutil\CMakeFiles\dsymutil.dir\CFBundle.cpp.obj
566.240 [495/10/5874] Building CXX object tools\dsymutil\CMakeFiles\dsymutil.dir\BinaryHolder.cpp.obj
566.249 [494/10/5875] Building CXX object tools\bugpoint\CMakeFiles\bugpoint.dir\bugpoint.cpp.obj
566.273 [493/10/5876] Building RC object tools\bugpoint\CMakeFiles\bugpoint.dir\__\__\resources\windows_version_resource.rc.res
566.306 [492/10/5877] Building CXX object tools\clang\tools\libclang\CMakeFiles\libclang.dir\CXExtractAPI.cpp.obj
FAILED: tools/clang/tools/libclang/CMakeFiles/libclang.dir/CXExtractAPI.cpp.obj 
ccache C:\Users\tcwg\scoop\apps\llvm\current\bin\clang-cl.exe  /nologo -TP -DGTEST_HAS_RTTI=0 -DUNICODE -D_CINDEX_LIB_ -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_HAS_EXCEPTIONS=0 -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -IC:\Users\tcwg\llvm-worker\lldb-aarch64-windows\build\tools\clang\tools\libclang -IC:\Users\tcwg\llvm-worker\lldb-aarch64-windows\llvm-project\clang\tools\libclang -IC:\Users\tcwg\llvm-worker\lldb-aarch64-windows\llvm-project\clang\include -IC:\Users\tcwg\llvm-worker\lldb-aarch64-windows\build\tools\clang\include -IC:\Users\tcwg\llvm-worker\lldb-aarch64-windows\build\include -IC:\Users\tcwg\llvm-worker\lldb-aarch64-windows\llvm-project\llvm\include /DWIN32 /D_WINDOWS   /Zc:inline /Zc:__cplusplus /Oi /Brepro /bigobj /permissive- -Werror=unguarded-availability-new /W4  -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported /Gw /O2 /Ob2 /DNDEBUG -std:c++17 -MD  /EHs-c- /GR- /showIncludes /Fotools\clang\tools\libclang\CMakeFiles\libclang.dir\CXExtractAPI.cpp.obj /Fdtools\clang\tools\libclang\CMakeFiles\libclang.dir\ -c -- C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\llvm-project\clang\tools\libclang\CXExtractAPI.cpp
In file included from C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\llvm-project\clang\tools\libclang\CXExtractAPI.cpp:25:
C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\llvm-project\clang\include\clang/ExtractAPI/ExtractAPIVisitor.h(164,38): error: member access into incomplete type 'SourceManager'
  164 |     return Context.getSourceManager().isInSystemHeader(D->getLocation());
      |                                      ^
C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\llvm-project\clang\include\clang/Basic/SourceLocation.h(34,7): note: forward declaration of 'clang::SourceManager'
   34 | class SourceManager;
      |       ^
In file included from C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\llvm-project\clang\tools\libclang\CXExtractAPI.cpp:25:
C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\llvm-project\clang\include\clang/ExtractAPI/ExtractAPIVisitor.h(293,33): error: member access into incomplete type 'SourceManager'
  293 |       Context.getSourceManager().getPresumedLoc(Decl->getLocation());
      |                                 ^
C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\llvm-project\clang\include\clang/Basic/SourceLocation.h(34,7): note: forward declaration of 'clang::SourceManager'
   34 | class SourceManager;
      |       ^
In file included from C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\llvm-project\clang\tools\libclang\CXExtractAPI.cpp:25:
C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\llvm-project\clang\include\clang/ExtractAPI/ExtractAPIVisitor.h(366,33): error: member access into incomplete type 'SourceManager'
  366 |       Context.getSourceManager().getPresumedLoc(Decl->getLocation());
      |                                 ^
C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\llvm-project\clang\include\clang/Basic/SourceLocation.h(34,7): note: forward declaration of 'clang::SourceManager'
   34 | class SourceManager;
      |       ^
In file included from C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\llvm-project\clang\tools\libclang\CXExtractAPI.cpp:25:
C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\llvm-project\clang\include\clang/ExtractAPI/ExtractAPIVisitor.h(404,33): error: member access into incomplete type 'SourceManager'
  404 |       Context.getSourceManager().getPresumedLoc(Decl->getLocation());
      |                                 ^
C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\llvm-project\clang\include\clang/Basic/SourceLocation.h(34,7): note: forward declaration of 'clang::SourceManager'
   34 | class SourceManager;
      |       ^
In file included from C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\llvm-project\clang\tools\libclang\CXExtractAPI.cpp:25:
C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\llvm-project\clang\include\clang/ExtractAPI/ExtractAPIVisitor.h(535,33): error: member access into incomplete type 'SourceManager'
  535 |       Context.getSourceManager().getPresumedLoc(Decl->getLocation());
      |                                 ^
C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\llvm-project\clang\include\clang/Basic/SourceLocation.h(34,7): note: forward declaration of 'clang::SourceManager'
   34 | class SourceManager;
      |       ^
In file included from C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\llvm-project\clang\tools\libclang\CXExtractAPI.cpp:25:
C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\llvm-project\clang\include\clang/ExtractAPI/ExtractAPIVisitor.h(581,33): error: member access into incomplete type 'SourceManager'

```

https://github.com/llvm/llvm-project/pull/104600