[clang] [clang][ExtractAPI] Stop dropping fields of nested anonymous record types when they aren't attached to variable declaration (PR #104600)

Mon Aug 19 08:00:32 PDT 2024

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `llvm-x86_64-debian-dylib` running on `gribozavr4` while building `clang` at step 5 "build-unified-tree".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/60/builds/5320

Here is the relevant piece of the build log for the reference:
```
Step 5 (build-unified-tree) failure: build (failure)
...
43.795 [983/55/5918] Building CXX object tools/clang/tools/extra/clangd/CMakeFiles/obj.clangDaemon.dir/index/dex/PostingList.cpp.o
43.796 [983/54/5919] Building CXX object tools/clang/tools/extra/clangd/CMakeFiles/obj.clangDaemon.dir/index/dex/Trigram.cpp.o
43.796 [983/53/5920] Building CXX object tools/clang/tools/extra/clangd/tool/CMakeFiles/clangd.dir/ClangdToolMain.cpp.o
43.796 [983/52/5921] Building CXX object tools/clang/tools/extra/clangd/fuzzer/CMakeFiles/clangd-fuzzer.dir/FuzzerClangdMain.cpp.o
43.796 [983/51/5922] Building CXX object tools/clang/tools/extra/clangd/CMakeFiles/obj.clangDaemon.dir/ScanningProjectModules.cpp.o
43.797 [983/50/5923] Building CXX object tools/clang/tools/extra/clangd/CMakeFiles/obj.clangDaemon.dir/index/MemIndex.cpp.o
43.797 [983/49/5924] Building CXX object tools/clang/tools/extra/clangd/CMakeFiles/obj.clangDaemon.dir/index/dex/Dex.cpp.o
43.798 [983/48/5925] Building CXX object tools/clang/tools/extra/clangd/CMakeFiles/obj.clangDaemon.dir/refactor/InsertionPoint.cpp.o
43.799 [983/47/5926] Building CXX object tools/clang/tools/extra/clangd/CMakeFiles/obj.clangDaemon.dir/CompletionModel.cpp.o
44.003 [983/46/5927] Building CXX object tools/clang/tools/libclang/CMakeFiles/libclang.dir/CXExtractAPI.cpp.o
FAILED: tools/clang/tools/libclang/CMakeFiles/libclang.dir/CXExtractAPI.cpp.o 
CCACHE_CPP2=yes CCACHE_HASHDIR=yes /usr/bin/ccache /usr/bin/clang++ -DGTEST_HAS_RTTI=0 -D_CINDEX_LIB_ -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/b/1/llvm-x86_64-debian-dylib/build/tools/clang/tools/libclang -I/b/1/llvm-x86_64-debian-dylib/llvm-project/clang/tools/libclang -I/b/1/llvm-x86_64-debian-dylib/llvm-project/clang/include -I/b/1/llvm-x86_64-debian-dylib/build/tools/clang/include -I/b/1/llvm-x86_64-debian-dylib/build/include -I/b/1/llvm-x86_64-debian-dylib/llvm-project/llvm/include -fPIC -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -fno-common -Woverloaded-virtual -Wno-nested-anon-types -O3 -DNDEBUG -fPIC  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -std=c++17 -MD -MT tools/clang/tools/libclang/CMakeFiles/libclang.dir/CXExtractAPI.cpp.o -MF tools/clang/tools/libclang/CMakeFiles/libclang.dir/CXExtractAPI.cpp.o.d -o tools/clang/tools/libclang/CMakeFiles/libclang.dir/CXExtractAPI.cpp.o -c /b/1/llvm-x86_64-debian-dylib/llvm-project/clang/tools/libclang/CXExtractAPI.cpp
In file included from /b/1/llvm-x86_64-debian-dylib/llvm-project/clang/tools/libclang/CXExtractAPI.cpp:25:
/b/1/llvm-x86_64-debian-dylib/llvm-project/clang/include/clang/ExtractAPI/ExtractAPIVisitor.h:164:38: error: member access into incomplete type 'clang::SourceManager'
    return Context.getSourceManager().isInSystemHeader(D->getLocation());
                                     ^
/b/1/llvm-x86_64-debian-dylib/llvm-project/clang/include/clang/Basic/SourceLocation.h:34:7: note: forward declaration of 'clang::SourceManager'
class SourceManager;
      ^
In file included from /b/1/llvm-x86_64-debian-dylib/llvm-project/clang/tools/libclang/CXExtractAPI.cpp:25:
/b/1/llvm-x86_64-debian-dylib/llvm-project/clang/include/clang/ExtractAPI/ExtractAPIVisitor.h:293:33: error: member access into incomplete type 'clang::SourceManager'
      Context.getSourceManager().getPresumedLoc(Decl->getLocation());
                                ^
/b/1/llvm-x86_64-debian-dylib/llvm-project/clang/include/clang/Basic/SourceLocation.h:34:7: note: forward declaration of 'clang::SourceManager'
class SourceManager;
      ^
In file included from /b/1/llvm-x86_64-debian-dylib/llvm-project/clang/tools/libclang/CXExtractAPI.cpp:25:
/b/1/llvm-x86_64-debian-dylib/llvm-project/clang/include/clang/ExtractAPI/ExtractAPIVisitor.h:366:33: error: member access into incomplete type 'clang::SourceManager'
      Context.getSourceManager().getPresumedLoc(Decl->getLocation());
                                ^
/b/1/llvm-x86_64-debian-dylib/llvm-project/clang/include/clang/Basic/SourceLocation.h:34:7: note: forward declaration of 'clang::SourceManager'
class SourceManager;
      ^
In file included from /b/1/llvm-x86_64-debian-dylib/llvm-project/clang/tools/libclang/CXExtractAPI.cpp:25:
/b/1/llvm-x86_64-debian-dylib/llvm-project/clang/include/clang/ExtractAPI/ExtractAPIVisitor.h:404:33: error: member access into incomplete type 'clang::SourceManager'
      Context.getSourceManager().getPresumedLoc(Decl->getLocation());
                                ^
/b/1/llvm-x86_64-debian-dylib/llvm-project/clang/include/clang/Basic/SourceLocation.h:34:7: note: forward declaration of 'clang::SourceManager'
class SourceManager;
      ^
In file included from /b/1/llvm-x86_64-debian-dylib/llvm-project/clang/tools/libclang/CXExtractAPI.cpp:25:
/b/1/llvm-x86_64-debian-dylib/llvm-project/clang/include/clang/ExtractAPI/ExtractAPIVisitor.h:535:33: error: member access into incomplete type 'clang::SourceManager'
      Context.getSourceManager().getPresumedLoc(Decl->getLocation());
                                ^
/b/1/llvm-x86_64-debian-dylib/llvm-project/clang/include/clang/Basic/SourceLocation.h:34:7: note: forward declaration of 'clang::SourceManager'
class SourceManager;
      ^
In file included from /b/1/llvm-x86_64-debian-dylib/llvm-project/clang/tools/libclang/CXExtractAPI.cpp:25:
/b/1/llvm-x86_64-debian-dylib/llvm-project/clang/include/clang/ExtractAPI/ExtractAPIVisitor.h:581:33: error: member access into incomplete type 'clang::SourceManager'

```

https://github.com/llvm/llvm-project/pull/104600