[clang] [clang][NFC] Split invalid-cpu-note tests (PR #104601)
Sam Elliott via cfe-commits
cfe-commits at lists.llvm.org
Mon Aug 19 07:05:44 PDT 2024
================
@@ -0,0 +1,90 @@
+// Use --implicit-check-not to ensure no additional CPUs are in this list
+
+// RUN: not %clang_cc1 -triple arm64--- -target-cpu not-a-cpu -fsyntax-only %s 2>&1 | FileCheck %s --implicit-check-not={{[a-zA-Z0-9]}}
+// RUN: not %clang_cc1 -triple arm64--- -tune-cpu not-a-cpu -fsyntax-only %s 2>&1 | FileCheck %s --implicit-check-not={{[a-zA-Z0-9]}}
+
+// CHECK: error: unknown target CPU 'not-a-cpu'
+// CHECK-NEXT: note: valid target CPU values are:
+// CHECK-SAME: a64fx,
----------------
lenary wrote:
I am not going to group them, I think one per line is more maintainable long-term for a few different reasons - it means no rewrapping diffs, no having to reverse engineer how someone grouped things, and that it's very obvious what to do for new CPUs.
I have taken the advice on using `{{^}}`
https://github.com/llvm/llvm-project/pull/104601
More information about the cfe-commits
mailing list