[clang] Fix typo in SanitizerCoverage.rst (PR #104715)

Marco Vanotti via cfe-commits cfe-commits at lists.llvm.org
Sun Aug 18 09:03:48 PDT 2024


https://github.com/mvanotti updated https://github.com/llvm/llvm-project/pull/104715

>From 43acabf1cbdd21d008c905f5842681fcdfd2cabd Mon Sep 17 00:00:00 2001
From: Marco Vanotti <mvanotti at users.noreply.github.com>
Date: Sun, 18 Aug 2024 11:59:07 -0400
Subject: [PATCH 1/2] Fix typo in SanitizerCoverage.rst

The callback for indirect calls is `__sanitizer_cov_trace_pc_indir`, not `__sanitizer_cov_trace_pc_indirect`.

See: https://github.com/llvm/llvm-project/blob/de5ea2d122c31e1551654ff506c33df299f351b8/compiler-rt/lib/sanitizer_common/sanitizer_interface_internal.h#L120
---
 clang/docs/SanitizerCoverage.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/clang/docs/SanitizerCoverage.rst b/clang/docs/SanitizerCoverage.rst
index 45ad03cb43774c..e5bfcb554e6b2b 100644
--- a/clang/docs/SanitizerCoverage.rst
+++ b/clang/docs/SanitizerCoverage.rst
@@ -37,7 +37,7 @@ The compiler will also insert calls to a module constructor:
    __sanitizer_cov_trace_pc_guard_init(uint32_t *start, uint32_t *stop);
 
 With an additional ``...=trace-pc,indirect-calls`` flag
-``__sanitizer_cov_trace_pc_indirect(void *callee)`` will be inserted on every indirect call.
+``__sanitizer_cov_trace_pc_indir(void *callee)`` will be inserted on every indirect call.
 
 The functions `__sanitizer_cov_trace_pc_*` should be defined by the user.
 

>From 83b0e100751be91fd14ab9f5157a2327d9802f9d Mon Sep 17 00:00:00 2001
From: Marco Vanotti <mvanotti at users.noreply.github.com>
Date: Sun, 18 Aug 2024 12:03:40 -0400
Subject: [PATCH 2/2] Update SanitizerCoverage.rst

---
 clang/docs/SanitizerCoverage.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/clang/docs/SanitizerCoverage.rst b/clang/docs/SanitizerCoverage.rst
index e5bfcb554e6b2b..af37398854ed07 100644
--- a/clang/docs/SanitizerCoverage.rst
+++ b/clang/docs/SanitizerCoverage.rst
@@ -200,7 +200,7 @@ Tracing PCs
 With ``-fsanitize-coverage=trace-pc`` the compiler will insert
 ``__sanitizer_cov_trace_pc()`` on every edge.
 With an additional ``...=trace-pc,indirect-calls`` flag
-``__sanitizer_cov_trace_pc_indirect(void *callee)`` will be inserted on every indirect call.
+``__sanitizer_cov_trace_pc_indir(void *callee)`` will be inserted on every indirect call.
 These callbacks are not implemented in the Sanitizer run-time and should be defined
 by the user.
 This mechanism is used for fuzzing the Linux kernel



More information about the cfe-commits mailing list