[clang] [clang][bytecode] Fix 'if consteval' in non-constant contexts (PR #104707)
Timm Baeder via cfe-commits
cfe-commits at lists.llvm.org
Sun Aug 18 07:29:47 PDT 2024
================
@@ -4368,8 +4363,19 @@ template <class Emitter> bool Compiler<Emitter>::visitIfStmt(const IfStmt *IS) {
if (!visitDeclStmt(CondDecl))
return false;
- if (!this->visitBool(IS->getCond()))
- return false;
+ // Compile condition.
+ if (IS->isNonNegatedConsteval()) {
+ if (!this->emitIsConstantContext(IS))
+ return false;
+ } else if (IS->isNegatedConsteval()) {
+ if (!this->emitIsConstantContext(IS))
+ return false;
+ if (!this->emitInv(IS))
+ return false;
+ } else {
+ if (!this->visitBool(IS->getCond()))
+ return false;
+ }
----------------
tbaederr wrote:
That's what the previous code did, though. That doesn't work if we compile to bytecode and later interpret the same bytecode in a non-constant context.
https://github.com/llvm/llvm-project/pull/104707
More information about the cfe-commits
mailing list