[clang] [clang][NFC] Split invalid-cpu-note tests (PR #104601)

Tomas Matheson via cfe-commits cfe-commits at lists.llvm.org
Sat Aug 17 10:02:43 PDT 2024


================
@@ -0,0 +1,90 @@
+// Use --implicit-check-not to ensure no additional CPUs are in this list
+
+// RUN: not %clang_cc1 -triple arm64--- -target-cpu not-a-cpu -fsyntax-only %s 2>&1 | FileCheck %s --implicit-check-not={{[a-zA-Z0-9]}}
+// RUN: not %clang_cc1 -triple arm64--- -tune-cpu not-a-cpu -fsyntax-only %s 2>&1 | FileCheck %s --implicit-check-not={{[a-zA-Z0-9]}}
+
+// CHECK: error: unknown target CPU 'not-a-cpu'
+// CHECK-NEXT: note: valid target CPU values are:
+// CHECK-SAME: a64fx,
----------------
tmatheson-arm wrote:

What would be the advantage though? Fewer test lines? It's more work to group them. And sometimes we have downstream additions to processor families which would make resolving diffs more difficult if they appear mid-group.

https://github.com/llvm/llvm-project/pull/104601


More information about the cfe-commits mailing list