[clang] [Clang] fix crash by avoiding invalidation of extern main declaration during strictness checks (PR #104594)

[Oleksandr T. via cfe-commits]

================
@@ -78,12 +80,12 @@ namespace ns {
 extern "C" struct A { int main(); }; // ok
 
 namespace c {
-  extern "C" void main(); // expected-warning {{'main' should not be 'extern "C"'}}
+  extern "C" int main(); // expected-warning {{'main' should not be 'extern "C"'}}
 }
 
 extern "C" {
   namespace Z {
-    void main(); // expected-warning {{'main' should not be 'extern "C"'}}
----------------
a-tarasyuk wrote:

To avoid unnecessary diagnostics and only validate invalid linkage for the main function, since the main function will not be interrupted by invalid usage. Should I revert it?

https://github.com/llvm/llvm-project/pull/104594