[clang-tools-extra] [clang-tidy] use upper case letters for bool conversion suffix (PR #102831)

Oliver Stöneberg via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 15 15:10:40 PDT 2024


firewave wrote:

I do not think this logic should be added to a check and should stay in a single place as it is right now.

> A bit of nitpick, but would it make sense to have some consistency with `readability-identifier-naming`?

As pointed out here this logic now exists in three different places with different ways of configuring it.

An inconsistency is that `readability-uppercase-literal-suffix` only handles `l` and `u` by default whereas the check here also handles `f`. So if code is modified by this it will add `F` to the code which might not be desired. So you also need to configure which suffices to make uppercase here.

https://github.com/llvm/llvm-project/pull/102831


More information about the cfe-commits mailing list