[clang] [clang-format] Change BinPackParameters to an enum to add a BreakAlways (PR #101882)

Owen Pan via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 15 01:48:17 PDT 2024


owenca wrote:

> Whilst I can understand BinPackParameters being deprecated, as its one of the original options I do worry a little about just how much impact such a deprecation might have... it needs to be completely seemless because there is ALOT of documentation references to its use on say stackoverflow. etc...
> 
> One reason I suggested making the change without renaming the option was the level of flux the name change was having. 

I had never reviewed a similar PR (until #96804) let alone having worked on one. Now I understand it's better to keep the option name even if it's confusing.

https://github.com/llvm/llvm-project/pull/101882


More information about the cfe-commits mailing list