[clang] [llvm] [Offload] Provide a kernel library useable by the offload runtime (PR #104168)
via cfe-commits
cfe-commits at lists.llvm.org
Wed Aug 14 12:00:40 PDT 2024
github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git-clang-format --diff d213981c80626698a07b11ce872acba098a863d4 defcf1effca6b441fc687477f406295601806163 --extensions cpp,c,h -- offload/src/Kernels/Memory.cpp offload/test/offloading/kernels_memset.c clang/lib/Driver/ToolChains/CommonArgs.cpp offload/include/device.h offload/include/omptarget.h offload/plugins-nextgen/amdgpu/src/rtl.cpp offload/plugins-nextgen/common/include/PluginInterface.h offload/plugins-nextgen/common/src/PluginInterface.cpp offload/plugins-nextgen/cuda/src/rtl.cpp offload/plugins-nextgen/host/src/rtl.cpp offload/src/OpenMP/API.cpp offload/src/device.cpp offload/src/interface.cpp offload/test/jit/type_punning.c
``````````
</details>
<details>
<summary>
View the diff from clang-format here.
</summary>
``````````diff
diff --git a/clang/lib/Driver/ToolChains/CommonArgs.cpp b/clang/lib/Driver/ToolChains/CommonArgs.cpp
index 071100a73c..4080356c63 100644
--- a/clang/lib/Driver/ToolChains/CommonArgs.cpp
+++ b/clang/lib/Driver/ToolChains/CommonArgs.cpp
@@ -1240,10 +1240,10 @@ bool tools::addOpenMPRuntime(const Compilation &C, ArgStringList &CmdArgs,
CmdArgs.push_back("-lrt");
if (IsOffloadingHost)
- CmdArgs.push_back("-lomptarget");
+ CmdArgs.push_back("-lomptarget");
if (IsOffloadingHost && !Args.hasArg(options::OPT_nogpulib))
- CmdArgs.append({"-lomptarget.devicertl", "-loffload.kernels"});
+ CmdArgs.append({"-lomptarget.devicertl", "-loffload.kernels"});
addArchSpecificRPath(TC, Args, CmdArgs);
diff --git a/offload/plugins-nextgen/common/src/PluginInterface.cpp b/offload/plugins-nextgen/common/src/PluginInterface.cpp
index e83477b5dd..3599ae61c7 100644
--- a/offload/plugins-nextgen/common/src/PluginInterface.cpp
+++ b/offload/plugins-nextgen/common/src/PluginInterface.cpp
@@ -2202,7 +2202,6 @@ int32_t GenericPluginTy::get_function(__tgt_device_binary Binary,
return OFFLOAD_FAIL;
}
-
// Note that this is not the kernel's device address.
*KernelPtr = &*KernelOrErr;
return OFFLOAD_SUCCESS;
``````````
</details>
https://github.com/llvm/llvm-project/pull/104168
More information about the cfe-commits
mailing list