[clang] [analyzer][NFC] Improve documentation of `invalidateRegion` methods (PR #102477)
DonĂ¡t Nagy via cfe-commits
cfe-commits at lists.llvm.org
Mon Aug 12 02:46:29 PDT 2024
NagyDonat wrote:
> Do you plan to apply more refactors to invalidation and Store?
These were opportunistic unplanned refactors, I was just familiarizing myself with the invalidation logic (because I'll need to use it in loop widening), and I quickly fixed some minor issues that I spotted.
However, I'll probably need one change to make more features of the invalidation logic accessible without a `CallEvent`. (Currently the `CallEvent` is passed down even to `RegionStoreManager::invalidateRegions` where it's only used to calculate an `enum GlobalsFilterKind` value; while I'd like to have a variant of `ProgramState::invalidateRegions` that directly takes a `GlobalFiltersKind` instead of a `CallEvent`.)
However I'm not planning any functional/algorithmic changes in the invalidation logic, and I think and hope that I won't need to touch other parts of the `State`.
What can I do to help you avoid merge conflicts?
https://github.com/llvm/llvm-project/pull/102477
More information about the cfe-commits
mailing list