[clang] [clang][analyzer] Remove array bounds check from PointerSubChecker (PR #102580)

[Donát Nagy via cfe-commits]

https://github.com/NagyDonat commented:

In the PR/commit message you write that

> At least theoretically the array bounds checker (when finalized) should find the same cases that were detected by the PointerSubChecker.

but I'm pretty sure that the array bound checker already does find all these cases (and much more complex cases as well). (The only remaining reason why ArrayBoundV2 is in alpha is that it emits too many false positives, because engine issues like the inaccurate modeling of loops feed it with incorrect information.)

Instead of deleting the array bound testcases, you could also enable ArrayBoundV2 in the pointer-sub test files and validate that it does find those reports.

Also note that the array bounds checker is named `ArrayBoundV2` with no "s" in the name.

https://github.com/llvm/llvm-project/pull/102580