[libunwind] [libunwind] Fix problems caused by combining BTI and GCS (PR #102322)

via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 7 08:06:44 PDT 2024


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff d06303ffc1f3b2023532fd426734e9435f87d038 1c6cbe68b3d2698cf5958daf84ec25496bb7589a --extensions h -- libunwind/src/assembly.h
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/libunwind/src/assembly.h b/libunwind/src/assembly.h
index f8e83e138e..ff004fe887 100644
--- a/libunwind/src/assembly.h
+++ b/libunwind/src/assembly.h
@@ -98,17 +98,12 @@
 #define AARCH64_BTI bti c
 #endif
 #ifdef GNU_PROPERTY
-  .pushsection ".note.gnu.property", "a" SEPARATOR                             \
-  .balign 8 SEPARATOR                                                          \
-  .long 4 SEPARATOR                                                            \
-  .long 0x10 SEPARATOR                                                         \
-  .long 0x5 SEPARATOR                                                          \
-  .asciz "GNU" SEPARATOR                                                       \
-  .long 0xc0000000 SEPARATOR /* GNU_PROPERTY_AARCH64_FEATURE_1_AND */          \
-  .long 4 SEPARATOR                                                            \
-  .long GNU_PROPERTY SEPARATOR                                                 \
-  .long 0 SEPARATOR                                                            \
-  .popsection SEPARATOR
+.pushsection ".note.gnu.property",
+    "a" SEPARATOR.balign 8 SEPARATOR.long 4 SEPARATOR.long 0x10 SEPARATOR
+        .long 0x5 SEPARATOR.asciz "GNU" SEPARATOR
+        .long 0xc0000000 SEPARATOR /* GNU_PROPERTY_AARCH64_FEATURE_1_AND */
+        .long 4 SEPARATOR.long GNU_PROPERTY SEPARATOR.long 0 SEPARATOR
+        .popsection SEPARATOR
 #endif
 #endif
 #if !defined(AARCH64_BTI)
@@ -117,12 +112,13 @@
 
 #if !defined(__aarch64__)
 #ifdef __ARM_FEATURE_PAC_DEFAULT
-  .eabi_attribute Tag_PAC_extension, 2
-  .eabi_attribute Tag_PACRET_use, 1
+        .eabi_attribute Tag_PAC_extension,
+    2 .eabi_attribute Tag_PACRET_use,
+    1
 #endif
 #ifdef __ARM_FEATURE_BTI_DEFAULT
-  .eabi_attribute Tag_BTI_extension, 1
-  .eabi_attribute Tag_BTI_use, 1
+        .eabi_attribute Tag_BTI_extension,
+    1 .eabi_attribute Tag_BTI_use, 1
 #endif
 #endif
 

``````````

</details>


https://github.com/llvm/llvm-project/pull/102322


More information about the cfe-commits mailing list